Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

component.create() metod rlc values and location bug fix #4083

Merged
merged 41 commits into from
Jan 16, 2024

Conversation

svandenb-dev
Copy link
Collaborator

component.create had some issue:

  • component wrong value
  • wrong location
    This PR is resolving these issues

# Conflicts:
#	pyaedt/edb_core/edb_data/primitives_data.py
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@svandenb-dev svandenb-dev changed the title Set component rlc compatible for all components component.create() metod rlc values and location bug fix Jan 16, 2024
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) January 16, 2024 08:28
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (ecda625) 81.79% compared to head (89b0b44) 79.31%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4083      +/-   ##
==========================================
- Coverage   81.79%   79.31%   -2.49%     
==========================================
  Files         184      184              
  Lines       63895    63905      +10     
==========================================
- Hits        52266    50685    -1581     
- Misses      11629    13220    +1591     

@Samuelopez-ansys Samuelopez-ansys merged commit 2ea82c7 into main Jan 16, 2024
15 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the set_component_rlc_compatible_for_all_components branch January 16, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

component.create() method when is_rlc=True assigning wrong values and location
2 participants