Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Json schema lib dependency fix #4090

Merged
merged 42 commits into from
Jan 17, 2024
Merged

Conversation

svandenb-dev
Copy link
Collaborator

jsonschema dependency fix

# Conflicts:
#	pyaedt/edb_core/edb_data/primitives_data.py
@svandenb-dev svandenb-dev added the dependencies Related with project dependencies label Jan 17, 2024
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the maintenance Package and maintenance related label Jan 17, 2024
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a7edfe6) 81.85% compared to head (163e4f1) 81.86%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4090   +/-   ##
=======================================
  Coverage   81.85%   81.86%           
=======================================
  Files         184      184           
  Lines       63987    63987           
=======================================
+ Hits        52378    52384    +6     
+ Misses      11609    11603    -6     

@Samuelopez-ansys Samuelopez-ansys merged commit 81b5f72 into main Jan 17, 2024
15 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the json_schema_lib_dependency_fix branch January 17, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Related with project dependencies maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants