Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added method to AnsysReport to retrieve design Info #4146

Merged
merged 6 commits into from
Feb 2, 2024

Conversation

maxcapodi78
Copy link
Collaborator

Furthermore I've fixed the docstrings for new_desktop_session variable that was not reflecting the default argument value

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the edb label Jan 29, 2024
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bbf6bdb) 81.95% compared to head (95b5d5f) 82.00%.
Report is 1 commits behind head on main.

❗ Current head 95b5d5f differs from pull request most recent head de56339. Consider uploading reports for the commit de56339 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4146      +/-   ##
==========================================
+ Coverage   81.95%   82.00%   +0.04%     
==========================================
  Files         182      182              
  Lines       63854    63887      +33     
==========================================
+ Hits        52334    52389      +55     
+ Misses      11520    11498      -22     

pyaedt/generic/pdf.py Outdated Show resolved Hide resolved
pyaedt/generic/pdf.py Outdated Show resolved Hide resolved
pyaedt/generic/pdf.py Outdated Show resolved Hide resolved
MaxJPRey
MaxJPRey previously approved these changes Jan 30, 2024
Copy link
Collaborator

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Samuelopez-ansys Samuelopez-ansys dismissed stale reviews from MaxJPRey and themself via fe368a8 February 2, 2024 12:48
Samuelopez-ansys and others added 4 commits February 2, 2024 13:48
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) February 2, 2024 12:48
@Samuelopez-ansys Samuelopez-ansys merged commit eea270a into main Feb 2, 2024
14 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the improve_report branch February 2, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants