Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove illegal character from variable name before variable creation #4168

Merged
merged 3 commits into from
Feb 3, 2024

Conversation

ring630
Copy link
Collaborator

@ring630 ring630 commented Feb 1, 2024

No description provided.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the edb label Feb 1, 2024
@ring630 ring630 linked an issue Feb 1, 2024 that may be closed by this pull request
2 tasks
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f73d1aa) 79.56% compared to head (204760a) 82.10%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4168      +/-   ##
==========================================
+ Coverage   79.56%   82.10%   +2.54%     
==========================================
  Files         183      183              
  Lines       64462    64464       +2     
==========================================
+ Hits        51287    52928    +1641     
+ Misses      13175    11536    -1639     

Copy link
Collaborator

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ring630
Copy link
Collaborator Author

ring630 commented Feb 1, 2024

@SMoraisAnsys EDB related PR

@ring630 ring630 enabled auto-merge (squash) February 1, 2024 12:56
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ring630 ring630 merged commit f012a22 into main Feb 3, 2024
15 checks passed
@ring630 ring630 deleted the auto_parameterizatoin_bug_fix branch February 3, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

illegal character is passed to variable name
3 participants