Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Add layout boundaries #4684

Merged
merged 2 commits into from
May 16, 2024
Merged

Conversation

Samuelopez-ansys
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys commented May 16, 2024

With this implementation, you can get the boundaries in a HFSS 3DLayout design, and then with the object_properties, you can manipulate these boundaries.

For instance:

aedtapp.boundaries[0].object_properties.props["Boundary Type"] = "PEC"

It was not possible before.

Close #3251

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) May 16, 2024 15:58
@codecov-commenter
Copy link

codecov-commenter commented May 16, 2024

Codecov Report

Attention: Patch coverage is 52.94118% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 75.79%. Comparing base (6785a3b) to head (4cc1e16).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4684   +/-   ##
=======================================
  Coverage   75.78%   75.79%           
=======================================
  Files         121      121           
  Lines       54810    54826   +16     
=======================================
+ Hits        41540    41553   +13     
- Misses      13270    13273    +3     

@Samuelopez-ansys Samuelopez-ansys merged commit b8801e2 into main May 16, 2024
33 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the feat/add_layout_boundaries branch May 16, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
3 participants