FIX: Export configuration and AEDT crash #4913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
maxcapodi78
commented
Jul 12, 2024
maxcapodi78
commented
- export_configuration method was failing under certain circumstances
- aedt_objects were still referenced after a project was closed and could cause crash in AEDT during debug mode.
- export_configuration method was failing under certain circumstances - aedt_objects were still referenced after a project was closed and could cause crash in AEDT during debug mode.
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
added 2 commits
July 12, 2024 13:20
SMoraisAnsys
previously approved these changes
Jul 12, 2024
SMoraisAnsys
changed the title
SMoraisAnsys
changed the title
SMoraisAnsys
previously approved these changes
Jul 12, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4913 +/- ##
==========================================
+ Coverage 79.12% 83.34% +4.21%
==========================================
Files 118 119 +1
Lines 54177 54328 +151
==========================================
+ Hits 42869 45277 +2408
+ Misses 11308 9051 -2257 |
maxcapodi78
dismissed stale reviews from SMoraisAnsys and Alberto-DM
via
c331c8a
added 2 commits
July 12, 2024 16:54
SMoraisAnsys
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.