Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Improved rmxprt robustness #4948

Merged
merged 6 commits into from
Jul 24, 2024
Merged

FEAT: Improved rmxprt robustness #4948

merged 6 commits into from
Jul 24, 2024

Conversation

maxcapodi78
Copy link
Collaborator

Added rmxprt example

Added rmxprt example
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added examples Anything related to the examples bug Something isn't working labels Jul 24, 2024
maxcapodi78 added 2 commits July 24, 2024 16:33
svandenb-dev
svandenb-dev previously approved these changes Jul 24, 2024
Copy link
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 46.47887% with 38 lines in your changes missing coverage. Please review.

Project coverage is 83.38%. Comparing base (5c07bf1) to head (104a1f4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4948      +/-   ##
==========================================
- Coverage   83.42%   83.38%   -0.05%     
==========================================
  Files         120      120              
  Lines       54458    54478      +20     
==========================================
- Hits        45434    45425       -9     
- Misses       9024     9053      +29     

Co-authored-by: Devin <38879940+dcrawforAtAnsys@users.noreply.github.com>
maxcapodi78 and others added 2 commits July 24, 2024 17:30
Co-authored-by: Devin <38879940+dcrawforAtAnsys@users.noreply.github.com>
Copy link
Contributor

@Devin-Crawford Devin-Crawford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@maxcapodi78 maxcapodi78 merged commit 28563d9 into main Jul 24, 2024
45 of 46 checks passed
@maxcapodi78 maxcapodi78 deleted the fix_rmxprt_bugs branch July 24, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working examples Anything related to the examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants