Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT: sketch elements enhancements #39

Closed
wants to merge 8 commits into from
Closed

FEAT: sketch elements enhancements #39

wants to merge 8 commits into from

Conversation

jorgepiloto
Copy link
Member

Adds additional properties to EllipseSketch and CircleSketch. Better integration with the Sketch class.

@github-actions github-actions bot added the enhancement New features or code improvements label Sep 1, 2022
@RobPasMue RobPasMue self-requested a review September 1, 2022 15:25
@jorgepiloto jorgepiloto force-pushed the feat/sketch-enhancements branch 3 times, most recently from b2928fb to 3559343 Compare September 2, 2022 08:28
@jorgepiloto jorgepiloto marked this pull request as ready for review September 2, 2022 12:18
@RobPasMue
Copy link
Member

RobPasMue commented Sep 4, 2022 •
edited
Loading

Hi @jorgepiloto! Following the new set of issues coming (and potentially restructuring of packages, see #49), I think we should try and merge this PR as soon as possible (starting on Monday of course). Afterwards we will focus on the package restructuring and solving the PRIORITY issues.

@RobPasMue RobPasMue mentioned this pull request Sep 4, 2022
Closed
6 tasks
@jorgepiloto
Copy link
Member Author

Closing this in favor of #53

@jorgepiloto jorgepiloto closed this Sep 5, 2022
@RobPasMue RobPasMue deleted the feat/sketch-enhancements branch October 5, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akaszynski akaszynski akaszynski left review comments

@RobPasMue RobPasMue RobPasMue left review comments

@MaxJPRey MaxJPRey MaxJPRey left review comments

Assignees

@jorgepiloto jorgepiloto

Labels
enhancement New features or code improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jorgepiloto @RobPasMue @akaszynski @MaxJPRey