Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: implement initial documentation layout #8

Merged
merged 4 commits into from
Aug 31, 2022
Merged

Conversation

jorgepiloto
Copy link
Member

Solves #5 by adding the different required sections.

@github-actions github-actions bot added documentation Improvements or additions to documentation maintenance Package and maintenance related labels Aug 30, 2022
@RobPasMue RobPasMue self-requested a review August 30, 2022 13:47
@jorgepiloto
Copy link
Member Author

Numpydoc validation complains about __version__ not having a docstring. Even after adding it to the variable, it still complains...

@jorgepiloto jorgepiloto force-pushed the doc/sections branch 2 times, most recently from d5a8edb to fdbabce Compare August 30, 2022 20:19
@jorgepiloto jorgepiloto changed the title Implement initial documentation layout DOC: implement initial documentation layout Aug 30, 2022
@jorgepiloto
Copy link
Member Author

I do not like the "hack" of ignoring missing docstrings but even after documenting "version", numpydoc-validation keep complaining.

@jorgepiloto jorgepiloto marked this pull request as ready for review August 31, 2022 06:27
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RobPasMue RobPasMue merged commit 6a1c9b5 into main Aug 31, 2022
@RobPasMue RobPasMue deleted the doc/sections branch August 31, 2022 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants