Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the arc shape. #81

Merged
merged 15 commits into from
Sep 12, 2022
Merged

Add the arc shape. #81

merged 15 commits into from
Sep 12, 2022

Conversation

MaxJPRey
Copy link
Contributor

Add the arc shape.

@github-actions github-actions bot added the enhancement New features or code improvements label Sep 12, 2022
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments but in general LGTM =) I'll approve after comment resolution

src/ansys/geometry/core/shapes/arc.py Outdated Show resolved Hide resolved
src/ansys/geometry/core/shapes/arc.py Outdated Show resolved Hide resolved
src/ansys/geometry/core/shapes/arc.py Show resolved Hide resolved
src/ansys/geometry/core/shapes/arc.py Show resolved Hide resolved
src/ansys/geometry/core/shapes/arc.py Show resolved Hide resolved
src/ansys/geometry/core/shapes/arc.py Outdated Show resolved Hide resolved
src/ansys/geometry/core/shapes/arc.py Outdated Show resolved Hide resolved
src/ansys/geometry/core/shapes/arc.py Outdated Show resolved Hide resolved
src/ansys/geometry/core/shapes/arc.py Show resolved Hide resolved
src/ansys/geometry/core/shapes/arc.py Show resolved Hide resolved
Maxjrey and others added 3 commits September 12, 2022 19:44
Co-authored-by: Roberto Pastor Muela <roberto.pastormuela@ansys.com>
Co-authored-by: Roberto Pastor Muela <roberto.pastormuela@ansys.com>
Co-authored-by: Roberto Pastor Muela <roberto.pastormuela@ansys.com>
@jorgepiloto
Copy link
Member

This fixes issue #50.

@RobPasMue RobPasMue self-requested a review September 12, 2022 19:00
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Merging =)

@RobPasMue RobPasMue enabled auto-merge (squash) September 12, 2022 19:00
@RobPasMue RobPasMue merged commit 85f61a1 into main Sep 12, 2022
@RobPasMue RobPasMue deleted the feat/arcs branch September 12, 2022 19:06
@RobPasMue RobPasMue linked an issue Sep 13, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Arc curve
4 participants