Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dpf composite backend 6.1 (23.2) and 7.0 (24.1) in parallel #299

Merged
merged 88 commits into from
Jul 7, 2023

Conversation

roosre
Copy link
Collaborator

@roosre roosre commented Jun 27, 2023

closes #66 .

This PR is needed to support the new DPF Composites backend which uses supoperators instead of the Failure- and SamplingPoint Operator.
This is achieved by

  • An implementation member was added to the composite model which refers to the actual implementation. The returned class is compatible with the used DPF server.
  • A protocol is used to implement the Sampling Point class. This allows to distinguish between the support server versions but have an unique API. See sampling_point_types.py.
  • Deprecation warnings were added where the composite_definition_label is used.
  • helper functions where added to check the dpf server version (see server_helpers/_versions.py)

@github-actions github-actions bot added the enhancement New features or code improvements label Jun 27, 2023
roosre added 28 commits June 28, 2023 11:07
janvonrickenbach and others added 19 commits July 7, 2023 09:21
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
…ite_failure_operator' into feat/more_suboperators_in_composite_failure_operator
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@codecov-commenter
Copy link

Codecov Report

Merging #299 (d4fd996) into main (36ffda0) will increase coverage by 0.11%.
The diff coverage is 89.64%.

❗ Current head d4fd996 differs from pull request most recent head d3dfb07. Consider uploading reports for the commit d3dfb07 to get more accurate results

@@            Coverage Diff             @@
##             main     #299      +/-   ##
==========================================
+ Coverage   91.52%   91.64%   +0.11%     
==========================================
  Files          39       47       +8     
  Lines        2313     2955     +642     
==========================================
+ Hits         2117     2708     +591     
- Misses        196      247      +51     
Impacted Files Coverage Δ
src/ansys/dpf/composites/__init__.py 71.42% <ø> (ø)
...f/composites/layup_info/_add_layup_info_to_mesh.py 83.33% <80.00%> (-3.04%) ⬇️
src/ansys/dpf/composites/composite_model.py 89.83% <82.85%> (+2.68%) ⬆️
src/ansys/dpf/composites/result_definition.py 88.48% <83.33%> (-0.65%) ⬇️
...sys/dpf/composites/_composite_model_impl_2023r2.py 85.81% <85.81%> (ø)
src/ansys/dpf/composites/_composite_model_impl.py 86.48% <86.48%> (ø)
src/ansys/dpf/composites/sampling_point_2023r2.py 87.19% <87.19%> (ø)
src/ansys/dpf/composites/data_sources.py 87.50% <87.50%> (-0.62%) ⬇️
...c/ansys/dpf/composites/server_helpers/_versions.py 90.90% <90.90%> (ø)
...rc/ansys/dpf/composites/_sampling_point_helpers.py 92.94% <92.94%> (ø)
... and 6 more

... and 1 file with indirect coverage changes

@roosre roosre merged commit 0d5ea83 into main Jul 7, 2023
@roosre roosre deleted the feat/more_suboperators_in_composite_failure_operator branch July 7, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fully support assemblies (core and python)
4 participants