Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add __getitem__, __setitem__ and get methods #390

Merged
merged 6 commits into from
May 2, 2024

Conversation

RajaPiseD
Copy link
Collaborator

@RajaPiseD RajaPiseD commented Apr 30, 2024

Description

Add getitem, setitem and get methods in Object class

Checklist

  • I have tested these changes locally.
  • I have added unit tests (if appropriate).
  • I have added necessary documentation or updated existing documentation.
  • I have linked the issue(s) addressed by this PR if any.

Copy link
Contributor

@FedericoNegri FedericoNegri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments. Please merge main into this branch and make sure checks pass.

src/ansys/hps/client/common/base_resource.py Outdated Show resolved Hide resolved
tests/rms/test_models.py Outdated Show resolved Hide resolved
tests/rms/test_models.py Outdated Show resolved Hide resolved
@RajaPiseD RajaPiseD marked this pull request as ready for review May 2, 2024 06:53
@RajaPiseD RajaPiseD self-assigned this May 2, 2024
Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.72%. Comparing base (cbfce9c) to head (5ddc20b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #390      +/-   ##
==========================================
+ Coverage   93.71%   93.72%   +0.01%     
==========================================
  Files          62       62              
  Lines        2402     2408       +6     
==========================================
+ Hits         2251     2257       +6     
  Misses        151      151              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RajaPiseD RajaPiseD merged commit 06b70a7 into main May 2, 2024
21 checks passed
@RajaPiseD RajaPiseD deleted the rajapise/object-class-add-dict-method branch May 2, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants