Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reformatting code blocks #2036

Merged
merged 8 commits into from
May 16, 2023
Merged

Reformatting code blocks #2036

merged 8 commits into from
May 16, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Apr 28, 2023

And small fixes

@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc Documentation labels Apr 28, 2023
@codecov
Copy link

codecov bot commented Apr 28, 2023 •
edited
Loading

Codecov Report

Merging #2036 (d5fed45) into main (a25fa9e) will increase coverage by 3.41%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2036      +/-   ##
==========================================
+ Coverage   82.98%   86.39%   +3.41%     
==========================================
  Files          44       45       +1     
  Lines        7932     7959      +27     
==========================================
+ Hits         6582     6876     +294     
+ Misses       1350     1083     -267

@germa89 germa89 requested review from a team and clatapie and removed request for a team May 3, 2023 11:32
@germa89 germa89 self-assigned this May 3, 2023
clatapie
clatapie approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The accept.txt file probably needs to be updated as I saw some failure regarding the vale action.

@germa89
Copy link
Collaborator Author

germa89 commented May 3, 2023

Waiting for this errata-ai/vale#619 before merging.

@germa89 germa89 added the Waiting label May 8, 2023
@github-actions github-actions bot removed the WAITING label May 8, 2023
@germa89 germa89 enabled auto-merge (squash) May 16, 2023 09:52
@germa89 germa89 merged commit 5f82a0b into main May 16, 2023
@germa89 germa89 deleted the doc/replacing-codeblocks branch May 16, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clatapie clatapie clatapie approved these changes

Assignees

@germa89 germa89

Labels
CI/CD Related with CICD, Github Actions, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@germa89 @clatapie