Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposing more internal properties. #2246

Merged
merged 2 commits into from
Aug 14, 2023
Merged

Exposing more internal properties. #2246

merged 2 commits into from
Aug 14, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Aug 11, 2023

As the title.

@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #2246 (2ffbcad) into main (e3885fb) will decrease coverage by 4.49%.
Report is 85 commits behind head on main.
The diff coverage is 89.30%.

@@            Coverage Diff             @@
##             main    #2246      +/-   ##
==========================================
- Coverage   86.39%   81.91%   -4.49%     
==========================================
  Files          45       45              
  Lines        7977     8328     +351     
==========================================
- Hits         6892     6822      -70     
- Misses       1085     1506     +421     

@germa89 germa89 enabled auto-merge (squash) August 11, 2023 17:41
@germa89 germa89 requested a review from clatapie August 11, 2023 17:41
Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@germa89 germa89 merged commit 6eb7455 into main Aug 14, 2023
22 checks passed
@germa89 germa89 deleted the feat/exposing-some-params branch August 14, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants