Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing post_processing plots #2295

Merged
merged 5 commits into from
Sep 4, 2023
Merged

Fixing post_processing plots #2295

merged 5 commits into from
Sep 4, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Sep 1, 2023

Fix the following issues:

Notes

PyMAPDL cmap does not work as cmap in pyvista.Plotter.add_mesh. We should fix that.

Close #2288
Close #2296

@germa89 germa89 self-assigned this Sep 1, 2023
@germa89 germa89 added BUG Issue, problem or error in PyMAPDL Critical Priority This issue affects almost all users labels Sep 1, 2023
@germa89 germa89 marked this pull request as draft September 1, 2023 11:58
Adding a cmap to avoid buggy plots
@germa89 germa89 changed the title Fixing empty post_processing plots Fixing post_processing plots Sep 4, 2023
@germa89 germa89 marked this pull request as ready for review September 4, 2023 09:14
@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Merging #2295 (0d8100f) into main (e3885fb) will increase coverage by 1.20%.
Report is 109 commits behind head on main.
The diff coverage is 92.45%.

@@            Coverage Diff             @@
##             main    #2295      +/-   ##
==========================================
+ Coverage   86.39%   87.59%   +1.20%     
==========================================
  Files          45       45              
  Lines        7977     8419     +442     
==========================================
+ Hits         6892     7375     +483     
+ Misses       1085     1044      -41     

Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It correctly renders on my local installation as well!

@germa89 germa89 enabled auto-merge (squash) September 4, 2023 10:50
@germa89 germa89 merged commit 19fcd61 into main Sep 4, 2023
21 of 22 checks passed
@germa89 germa89 deleted the fix/post_processing-plots branch September 4, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Issue, problem or error in PyMAPDL Critical Priority This issue affects almost all users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Buggy plotting in post_processing Post-processing not plotting results
2 participants