Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supporting launching MAPDL from WSL #2324

Merged
merged 19 commits into from
Sep 12, 2023
Merged

Supporting launching MAPDL from WSL #2324

merged 19 commits into from
Sep 12, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Sep 8, 2023 •
edited

And ofc, connecting to it.

However some guidance it is needed in order to allow WSL to connect to the MAPDL process running at the host.

Close #2315

@germa89 germa89 self-assigned this Sep 8, 2023
@github-actions github-actions bot added Enhancement Improve any current implemented feature New Feature Request or proposal for a new feature labels Sep 8, 2023
@codecov
Copy link

codecov bot commented Sep 8, 2023 •
edited

Codecov Report

Merging #2324 (95beb0d) into main (a2d1951) will increase coverage by 5.82%.
Report is 11 commits behind head on main.
The diff coverage is 77.16%.

@@            Coverage Diff             @@
##             main    #2324      +/-   ##
==========================================
+ Coverage   81.79%   87.61%   +5.82%     
==========================================
  Files          45       45              
  Lines        8435     8513      +78     
==========================================
+ Hits         6899     7459     +560     
+ Misses       1536     1054     -482

@germa89 germa89 mentioned this pull request Sep 8, 2023
Closed
RobPasMue
RobPasMue approved these changes Sep 10, 2023
View reviewed changes
src/ansys/mapdl/core/launcher.py Show resolved Hide resolved
@germa89 germa89 requested a review from PipKat September 12, 2023 15:29
@germa89
Copy link
Collaborator Author

germa89 commented Sep 12, 2023 •
edited

@PipKat Could you have a document review please?

germa89 and others added 4 commits September 12, 2023 18:10
@germa89 @PipKat
Apply suggestions from code review
e6fd9d9 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@germa89
More review suggetions
3559e4d
@germa89
Merge branch 'feat/allowing-wsl-to-launch-mapdl-instances' of https:/…
9c21ef0 
…/github.com/pyansys/pymapdl into feat/allowing-wsl-to-launch-mapdl-instances
@germa89 @PipKat
Apply suggestions from code review
ce05e6c 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@germa89 germa89 enabled auto-merge (squash) September 12, 2023 16:22
PipKat
PipKat approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@PipKat PipKat left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made suggestions for cleaning up a few wording issues.

germa89 and others added 5 commits September 12, 2023 19:06
@germa89 @PipKat
Apply suggestions from code review
5dfce9e 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
4ace284 
for more information, see https://pre-commit.ci
@germa89 @PipKat
Update src/ansys/mapdl/core/launcher.py
e8cfb9a 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@germa89
Fixing typo
f3f9e12
@germa89
Fixing links
95beb0d
@germa89 germa89 merged commit 1bd411a into main Sep 12, 2023
22 of 23 checks passed
@germa89 germa89 deleted the feat/allowing-wsl-to-launch-mapdl-instances branch September 12, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobPasMue RobPasMue RobPasMue approved these changes

@PipKat PipKat PipKat approved these changes

@clatapie clatapie Awaiting requested review from clatapie

Assignees

@germa89 germa89

Labels
Enhancement Improve any current implemented feature New Feature Request or proposal for a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Launching MAPDL from WSL
3 participants
@germa89 @RobPasMue @PipKat