Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving port being busy detection #2603

Merged
merged 11 commits into from
Jan 5, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jan 4, 2024

As the title.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Jan 4, 2024
@germa89 germa89 requested a review from clatapie January 4, 2024 10:05
@germa89 germa89 added the Enhancement Improve any current implemented feature label Jan 4, 2024
@github-actions github-actions bot added the New Feature Request or proposal for a new feature label Jan 4, 2024
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (0ceb0fb) 77.94% compared to head (2e85b9a) 79.74%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2603      +/-   ##
==========================================
+ Coverage   77.94%   79.74%   +1.80%     
==========================================
  Files          46       46              
  Lines        9118     9144      +26     
==========================================
+ Hits         7107     7292     +185     
+ Misses       2011     1852     -159     

@germa89
Copy link
Collaborator Author

germa89 commented Jan 5, 2024

Omitting coverage checks...

@germa89
Copy link
Collaborator Author

germa89 commented Jan 5, 2024

@pyansys-ci-bot LGTM

@germa89 germa89 enabled auto-merge (squash) January 5, 2024 10:49
Copy link
Collaborator

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

@germa89 germa89 merged commit 2dea105 into main Jan 5, 2024
26 of 28 checks passed
@germa89 germa89 deleted the feat/checking-port-is-busy-before-launching-MAPDL branch January 5, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improve any current implemented feature New Feature Request or proposal for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants