-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pdf file in releases #2665
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2665 +/- ##
==========================================
- Coverage 85.00% 82.97% -2.03%
==========================================
Files 47 47
Lines 9323 9322 -1
==========================================
- Hits 7925 7735 -190
- Misses 1398 1587 +189 |
I'm taking over this PR because @clatapie is busy with more important tasks. Basically there was two source of errors:
Also I did:
|
Ready to review @clatapie ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank @germa89 for having fixed it!
I can't approve it as I was the one opening the PR.
Closes #2660
See #2665 (comment)