Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pdf file in releases #2665

Merged
merged 19 commits into from
Feb 19, 2024
Merged

fix: pdf file in releases #2665

merged 19 commits into from
Feb 19, 2024

Conversation

clatapie
Copy link
Contributor

@clatapie clatapie commented Jan 15, 2024

Closes #2660

See #2665 (comment)

@clatapie clatapie self-assigned this Jan 15, 2024
@clatapie clatapie requested a review from a team as a code owner January 15, 2024 17:07
@clatapie clatapie linked an issue Jan 15, 2024 that may be closed by this pull request
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc Maintenance labels Jan 15, 2024
@clatapie clatapie marked this pull request as draft January 15, 2024 17:15
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (304ebb2) 85.00% compared to head (be73b37) 82.97%.
Report is 17 commits behind head on main.

❗ Current head be73b37 differs from pull request most recent head bb953c5. Consider uploading reports for the commit bb953c5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2665      +/-   ##
==========================================
- Coverage   85.00%   82.97%   -2.03%     
==========================================
  Files          47       47              
  Lines        9323     9322       -1     
==========================================
- Hits         7925     7735     -190     
- Misses       1398     1587     +189     

@germa89 germa89 assigned germa89 and unassigned clatapie Feb 14, 2024
@germa89
Copy link
Collaborator

germa89 commented Feb 15, 2024

I'm taking over this PR because @clatapie is busy with more important tasks.

Basically there was two source of errors:

  • Using GIFs in latex. It seems that importing GIFs files in latex was giving error (no bounding box, and not being able to open the files). This has been fixed by pre-processing those animated GIF files to convert them into static PNG. This conversion has been done in the new post_process_latex.py which replaces and expand validate_pngs.py
  • The usage of fontawesome in Latex which generates errors. Fixed by installing the fonts (texlive-fonts-extra) and suppressing those warnings.

Also I did:

  • Check PDF is not corrupted and can be opened with qpdf tool.
  • Reduce the size of the manifold.gif file.

@germa89 germa89 marked this pull request as ready for review February 15, 2024 08:50
@germa89
Copy link
Collaborator

germa89 commented Feb 15, 2024

Ready to review @clatapie !

Copy link
Contributor Author

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank @germa89 for having fixed it!
I can't approve it as I was the one opening the PR.

@germa89 germa89 merged commit 39a7d6a into main Feb 19, 2024
27 checks passed
@germa89 germa89 deleted the fix/pdf-build branch February 19, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Related with CICD, Github Actions, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PDF build is broken
2 participants