Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adapt PyMAPDL to common plotter #2799

Merged
merged 201 commits into from
Jul 16, 2024
Merged

Conversation

AlejandroFernandezLuces
Copy link
Contributor

@AlejandroFernandezLuces AlejandroFernandezLuces commented Feb 20, 2024

Overview

This PR adapts PyMAPDL to the usage of the common PyAnsys plotter. It seems that part of PyMAPDL plotter is in another repo, so this work is partially done until I figure out how to modify this other part.

As a side effect, this implementation won't allow pyvista subplotting.

To summarize, on top of improving maintainability by keeping some common plotting code in the same location, this adds the following features:

  • Change view buttons
  • Displacement buttons
  • Ruler widget to measure distances in the plotter
  • Measure box widget
  • Option to filter the meshes by a regex
  • Option to add custom buttons to the plotter

Screenshot of how the plotter looks now:

image

Missing:

  • Document and add comments where needed
  • Adapt picker to use common plotter picker
  • Adapt the other part of PyMAPDL

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is great. I left some minor comments. Thank you @AlejandroFernandezLuces !!

src/ansys/mapdl/core/mapdl_extended.py Outdated Show resolved Hide resolved
src/ansys/mapdl/core/mapdl_extended.py Outdated Show resolved Hide resolved
@AlejandroFernandezLuces
Copy link
Contributor Author

Not sure how to force the bot to rename the changelog file, I can't do it manually, do you know how @clatapie?

@clatapie clatapie added examples Publishing PyMAPDL examples documentation Documentation related (improving, adding, etc) and removed CI/CD Related with CICD, Github Actions, etc examples Publishing PyMAPDL examples documentation Documentation related (improving, adding, etc) maintenance General maintenance of the repo (libraries, cicd, etc) labels Jul 15, 2024
@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc examples Publishing PyMAPDL examples documentation Documentation related (improving, adding, etc) dependencies maintenance General maintenance of the repo (libraries, cicd, etc) labels Jul 15, 2024
@clatapie clatapie added the enhancement Improve any current implemented feature label Jul 15, 2024
@AlejandroFernandezLuces
Copy link
Contributor Author

Since this is a big change, I'll wait a bit more before merging just in case anyone has any more feedback. Thanks @germa89 @clatapie @PipKat for your feedback 🚀

Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR, I am happy to see it within PyMAPDL!

@AlejandroFernandezLuces
Copy link
Contributor Author

Merging, thanks everyone again 😄

@AlejandroFernandezLuces AlejandroFernandezLuces merged commit 5d17fdc into main Jul 16, 2024
49 checks passed
@AlejandroFernandezLuces AlejandroFernandezLuces deleted the feat/common-plotter branch July 16, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Related with CICD, Github Actions, etc dependencies documentation Documentation related (improving, adding, etc) enhancement Improve any current implemented feature examples Publishing PyMAPDL examples maintenance General maintenance of the repo (libraries, cicd, etc) new feature Request or proposal for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants