Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update the general files to align with PyAnsys standards #3151

Merged
merged 7 commits into from
Jun 4, 2024

Conversation

Revathyvenugopal162
Copy link
Contributor

@Revathyvenugopal162 Revathyvenugopal162 commented Jun 3, 2024

  • update pyproject.toml file
  • update authors file
  • update codeowners files
  • Add contributors file

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.15%. Comparing base (28b0b69) to head (66bd540).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3151      +/-   ##
==========================================
- Coverage   86.61%   84.15%   -2.47%     
==========================================
  Files          52       52              
  Lines        9528     9528              
==========================================
- Hits         8253     8018     -235     
- Misses       1275     1510     +235     

README.md Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
@jorgepiloto
Copy link
Member

What about the minimum_requirements.txt file placed in the root of the project?

Co-authored-by: Jorge Martínez <28702884+jorgepiloto@users.noreply.github.com>
@Revathyvenugopal162
Copy link
Contributor Author

What about the minimum_requirements.txt file placed in the root of the project?

Yes, we need to change it. However, I believe they are currently uploading it as artifacts, so altering this process might require reworking the CI/CD pipeline and possibly some documentation. Therefore, I thought of opening another PR to address those issues, if that’s alright with you.

Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far, it looks good to me :)

CONTRIBUTORS.md Outdated Show resolved Hide resolved
Revathyvenugopal162 and others added 2 commits June 4, 2024 08:36
Co-authored-by: German <28149841+germa89@users.noreply.github.com>
@jorgepiloto
Copy link
Member

Related with #3113

@Revathyvenugopal162 Revathyvenugopal162 merged commit 3dcb798 into main Jun 4, 2024
33 checks passed
@Revathyvenugopal162 Revathyvenugopal162 deleted the fix/common-files branch June 4, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants