-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update the general files to align with PyAnsys standards #3151
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3151 +/- ##
==========================================
- Coverage 86.61% 84.15% -2.47%
==========================================
Files 52 52
Lines 9528 9528
==========================================
- Hits 8253 8018 -235
- Misses 1275 1510 +235 |
What about the |
Co-authored-by: Jorge Martínez <28702884+jorgepiloto@users.noreply.github.com>
Yes, we need to change it. However, I believe they are currently uploading it as artifacts, so altering this process might require reworking the CI/CD pipeline and possibly some documentation. Therefore, I thought of opening another PR to address those issues, if that’s alright with you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far, it looks good to me :)
Co-authored-by: German <28149841+germa89@users.noreply.github.com>
Related with #3113 |
pyproject.toml
fileauthors
filecodeowners
filescontributors
file