-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Register __del__ method of TwinModel to avoid issue atexit #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #116 +/- ##
==========================================
- Coverage 89.04% 88.86% -0.19%
==========================================
Files 11 11
Lines 2336 2334 -2
==========================================
- Hits 2080 2074 -6
- Misses 256 260 +4 |
lboucin
changed the title
FIX Register __del__ method of TwinModel to avoid issue atexit
[FIX] Register __del__ method of TwinModel to avoid issue atexit
Sep 19, 2023
chrpetre
approved these changes
Sep 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks Lucas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@chrpetre The error raised at the end of the example script execution was due to python interpreter calling the cleanup method register to atexit module in the pytwin.settings module before to call the del method of the TwinModel.
There was no issue if the example business logic is encapsulated into a main method and the main method called at the end of the script. I think this due to the order in which methods are registered by the interpreter, which follow a last in, last out pattern at process exit.
The solution I found is to explicitly register the del method of TwinModel object to the atexit module. When importing pytwin, the init.py script in called, and then the registration of the del method is done after the registration of the
settings.cleanup_temp_pytwin_working_directory
method, which should avoid it to try deleting log file of the runtime of the TwinModel before it to be closed.