Fix/read write modes #122
Merged
Fix/read write modes #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- refactor reading/writing functions of binary files and settings file - adapt the different examples accordingly
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## main #122 +/- ##
==========================================
- Coverage 88.86% 88.80% -0.06%
==========================================
Files 11 11
Lines 2334 2322 -12
==========================================
- Hits 2074 2062 -12
Misses 260 260 |
lboucin
reviewed
Oct 5, 2023
EDCarman
requested changes
Oct 5, 2023
|
thanks for the detailed review @EDCarman, these should be addressed |
EDCarman
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR implements changes to use numpy for
@EDCarman FYI