Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add poetry.lock file and update the files with pyansys guidelines #172

Merged
merged 29 commits into from
Oct 7, 2024

Conversation

Revathyvenugopal162
Copy link
Collaborator

@Revathyvenugopal162 Revathyvenugopal162 commented Oct 3, 2024

closes #174 #173

@Revathyvenugopal162 Revathyvenugopal162 marked this pull request as draft October 3, 2024 10:09
@github-actions github-actions bot added maintenance Package and maintenance related dependencies Related with project dependencies bug Something isn't working labels Oct 3, 2024
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 3, 2024
@github-actions github-actions bot added the testing Anything related to tests label Oct 4, 2024
@github-actions github-actions bot removed the testing Anything related to tests label Oct 4, 2024
@Revathyvenugopal162 Revathyvenugopal162 changed the title feat: migrate the project to flit and update the files with pyansys guidelines feat: add poetry.lock file and update the files with pyansys guidelines Oct 4, 2024
Copy link
Collaborator

@lboucin lboucin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thanks for the great maintenance work here @Revathyvenugopal162.
Also, I think some maintenance will have to be done on our windows VM to have the pipeline fully successful.
@chrpetre that is maybe the right time to do the move to a github hosted agent for windows related actions (I guess doc build is the last one still running on the VM right?)

@Revathyvenugopal162 Revathyvenugopal162 marked this pull request as ready for review October 4, 2024 13:19
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

pyproject.toml Show resolved Hide resolved
tox.ini Show resolved Hide resolved
Revathyvenugopal162 and others added 2 commits October 4, 2024 16:40
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
Copy link
Collaborator

@lboucin lboucin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the great work @Revathyvenugopal162!

@Revathyvenugopal162 Revathyvenugopal162 merged commit bd5685a into main Oct 7, 2024
22 checks passed
@Revathyvenugopal162 Revathyvenugopal162 deleted the fix/general-updates branch October 7, 2024 07:04
@chrpetre
Copy link
Collaborator

chrpetre commented Oct 7, 2024

thanks @Revathyvenugopal162 for all the updates here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Related with project dependencies documentation Improvements or additions to documentation maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MAINTENANCE] Missing or outdated CONTRIBUTORS.md file in ansys/pytwin
4 participants