-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add poetry.lock file and update the files with pyansys guidelines #172
Conversation
17841b9
to
de3836f
Compare
de3836f
to
512eb7a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! Thanks for the great maintenance work here @Revathyvenugopal162.
Also, I think some maintenance will have to be done on our windows VM to have the pipeline fully successful.
@chrpetre that is maybe the right time to do the move to a github hosted agent for windows related actions (I guess doc build is the last one still running on the VM right?)
b3eaae1
to
c483242
Compare
134a892
to
7122fb5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for the great work @Revathyvenugopal162!
thanks @Revathyvenugopal162 for all the updates here! |
closes #174 #173