feat(module: table): Add Align property for column #2045
Conversation
|
|
Codecov Report
@@ Coverage Diff @@
## master #2045 +/- ##
==========================================
+ Coverage 25.51% 27.42% +1.91%
==========================================
Files 488 512 +24
Lines 32193 24562 -7631
Branches 0 238 +238
==========================================
- Hits 8214 6737 -1477
+ Misses 23979 17789 -6190
- Partials 0 36 +36
Continue to review full report at Codecov.
|
components/table/ColumnBase.cs
Outdated
| { | ||
| string alignStyle = Align switch | ||
| { | ||
| ColumnAlign.Left => "text-align: left", |
There was a problem hiding this comment.
Looks like this switch option is never used due to the condition in line 156.
There was a problem hiding this comment.
But since it confused you, I deleted ColumnAlign.Left case.
components/table/ColumnBase.cs
Outdated
| private string _fixedStyle; | ||
|
|
||
| protected string FixedStyle => _fixedStyle; | ||
| protected string FixedStyle { get; private set; } |
There was a problem hiding this comment.
Why did you delete the _fixedStyle field?
There was a problem hiding this comment.
I decided to replace private field _fixedStyle and protected get-only FixedStyle property by one auto-property with protected get and private set. In terms of functionality, this is the same as it was before.
Do you have anything against this?
There was a problem hiding this comment.
IMO, I think we no need to change this field.
There was a problem hiding this comment.
Ok. I reverted these changes.
* feat(module: table): Add Align property * feat(module: table): Add Align property * feat(module: table): Add Align property
* feat(module: table): Add Align property * feat(module: table): Add Align property * feat(module: table): Add Align property
* feat(module: table): Add Align property * feat(module: table): Add Align property * feat(module: table): Add Align property
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self Check before Merge