Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: form): null reference exception #3815

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

ElderJames
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fiexed #3808

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

github-actions bot commented Apr 23, 2024

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 43.51%. Comparing base (88f6b90) to head (af3221a).

Files Patch % Lines
components/form/FormItem.razor 0.00% 0 Missing and 1 partial ⚠️
components/form/FormItem.razor.cs 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3815       +/-   ##
===========================================
+ Coverage    1.49%   43.51%   +42.02%     
===========================================
  Files         577      580        +3     
  Lines       27928    28220      +292     
  Branches     5667     5736       +69     
===========================================
+ Hits          417    12281    +11864     
+ Misses      27471    14923    -12548     
- Partials       40     1016      +976     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ElderJames ElderJames merged commit b654223 into master Apr 23, 2024
5 of 6 checks passed
@ElderJames ElderJames deleted the fix/form-item-null-ref branch April 23, 2024 15:58
@michaelcsikos
Copy link

Can we have a NuGet release for AntDesign and AntDesign.ProLayout with this fix?

@ElderJames
Copy link
Member Author

Please try the 0.19.0-rc.x release first, we will release generally available one in this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants