fix: form #737
Merged
fix: form #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jc9702507
commented
May 24, 2023
•
jc9702507
commented
- 添加是要是没有使用component2就报错
|
🎊 PR Preview 25dbf24 has been successfully built and deployed to https://ant-design-ant-design-mini-preview-pr-737.surge.sh 🕐 Build time: 255.447s
🤖 By surge-preview |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| const component2 = my.canIUse('component2'); | ||
| if (!component2) { | ||
| throw new Error('需要使用component2'); | ||
| } | ||
| this.setInitialValues(formConfig.initialValues || {}); | ||
| this.setRules(formConfig.rules || {}); | ||
| this.validateMessages = formConfig.validateMessages; |
There was a problem hiding this comment.
这是一个 TypeScript 类的代码片段，对 Form 类的构造函数进行了修改。主要改动如下：
- 新增了分类判断 component2 是否支持，并在不支持时抛出错误。
- 给表单设置了初始值和验证规则，并允许自定义验证提示信息。
代码看起来没有明显的 bug 风险，但仍有以下几点可以改进：
- 抛出的错误信息比较简单，建议给出更具体的错误信息，例如告诉用户是哪个组件或哪个 API 不支持 component2。
- 没有提供针对 validateMessages 属性的自定义方法，建议添加该方法以便在验证失败时可以输出更符合业务需求的提示信息。
- 应该考虑加入 Eslint 或 Prettier 等代码格式化工具，以保证代码风格的统一和可维护性。
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #737 +/- ##
==========================================
- Coverage 24.01% 24.00% -0.02%
==========================================
Files 158 158
Lines 3339 3341 +2
Branches 875 876 +1
==========================================
Hits 802 802
- Misses 2206 2207 +1
- Partials 331 332 +1
☔ View full report in Codecov by Sentry. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.