Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toast add global config. #3304

Merged
merged 1 commit into from
Jul 12, 2019
Merged

Toast add global config. #3304

merged 1 commit into from
Jul 12, 2019

Conversation

fanzkday
Copy link
Contributor

@fanzkday fanzkday commented Jul 11, 2019

refer relative issues #3257

  • Make sure that you follow antd's code convention.

  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.

  • Rebase before creating a PR to keep commit history clear.

  • Add some descriptions and refer relative issues for you PR.

  • Update API docs for the component.

  • Update/Add demo to demonstrate new feature.

  • Update TypeScript definition for the component.

  • Add unit tests for the feature.


This change is Reviewable

@codecov
Copy link

codecov bot commented Jul 11, 2019

Codecov Report

Merging #3304 into master will decrease coverage by 0.11%.
The diff coverage is 22.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3304      +/-   ##
==========================================
- Coverage   64.87%   64.76%   -0.12%     
==========================================
  Files          92       92              
  Lines        2303     2310       +7     
  Branches      663      666       +3     
==========================================
+ Hits         1494     1496       +2     
- Misses        800      804       +4     
- Partials        9       10       +1
Flag Coverage Δ
#web 64.76% <22.22%> (-0.12%) ⬇️
Impacted Files Coverage Δ
components/toast/index.tsx 8.1% <22.22%> (+4.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cd1b53...10d5445. Read the comment docs.

@doxiaodong
Copy link
Contributor

thanks

@doxiaodong doxiaodong merged commit 723a208 into ant-design:master Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants