Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ellipsis): content could be undefined #5727

Merged
merged 3 commits into from
Oct 11, 2022

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Oct 11, 2022

close #5726

@github-actions
Copy link
Contributor

PR preview has been successfully built and deployed to https://antd-mobile-preview-pr-5727.surge.sh

@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2022

Size Change: +6 B (0%)

Total Size: 350 kB

Filename Size Change
./lib/bundle/antd-mobile.compatible.umd.js 188 kB +3 B (0%)
./lib/bundle/antd-mobile.umd.js 146 kB +3 B (0%)
ℹ️ View Unchanged
Filename Size
./lib/bundle/css-vars-patch.css 1.4 kB
./lib/bundle/style.css 14.6 kB

compressed-size-action

src/components/ellipsis/ellipsis.tsx Outdated Show resolved Hide resolved
@afc163 afc163 force-pushed the fix/Ellipsis-content-undefined branch from 3820660 to 48d6ea4 Compare October 11, 2022 10:02
@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Base: 89.91% // Head: 90.02% // Increases project coverage by +0.11% 🎉

Coverage data is based on head (d85bf53) compared to base (235b525).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5727      +/-   ##
==========================================
+ Coverage   89.91%   90.02%   +0.11%     
==========================================
  Files         297      297              
  Lines        6339     6339              
  Branches     1554     1554              
==========================================
+ Hits         5700     5707       +7     
+ Misses        590      584       -6     
+ Partials       49       48       -1     
Impacted Files Coverage Δ
src/components/ellipsis/ellipsis.tsx 99.13% <ø> (ø)
src/components/image-uploader/image-uploader.tsx 92.72% <0.00%> (+6.36%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@afc163 afc163 force-pushed the fix/Ellipsis-content-undefined branch from ded6c43 to 14b0deb Compare October 11, 2022 10:25
@afc163 afc163 force-pushed the fix/Ellipsis-content-undefined branch from 14b0deb to ef6cf90 Compare October 11, 2022 10:27
@afc163 afc163 requested a review from awmleer October 11, 2022 10:32
Copy link
Member

@awmleer awmleer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

Deploy PR preview failed.

1 similar comment
@github-actions
Copy link
Contributor

Deploy PR preview failed.

@afc163 afc163 merged commit 99500f4 into master Oct 11, 2022
@afc163 afc163 deleted the fix/Ellipsis-content-undefined branch October 11, 2022 13:57
@KingAmo
Copy link

KingAmo commented Oct 13, 2022

请问什么时候发新版本呢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants