feat: Support skip to guide in simple mode #532
Conversation
🦋 Changeset detectedLatest commit: 6c71dfd The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #532 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 650 650
Lines 17505 17558 +53
Branches 1071 1075 +4
=========================================
+ Hits 17505 17558 +53 ☔ View full report in Codecov by Sentry. |
|
需要覆盖一下单测 |
|
感觉没对齐 |
|
另外这个线应该是平齐两边的，高度是 70px（不过这个高度不一定对，我再找设计师确认下）
|
|
另外 footer 也存在的时候如何显示，现在是怎么处理的？ |
footer同时存在走footer逻辑，那么默认的 |
感觉两个应该都保留，是不一样的用途。 |
|
LearnMore 点击后应该显示： |
|
@wenqing993 文卿帮忙看看这个问题，看看下面这个两个元素在简单窗口模式下如何一起显示：
|
|
好的，我这边看一下 |
|
@shanchuan1 设计师那边这两天会有新的设计稿给到，稍微等一下 |
ok |
设计稿好了，我在 issue 中回复了。 |
|
@shanchuan1 同学这个pr你还有精力跟嘛，我可以帮忙一起看一下 |
simplemode.bug.mov@LCJove 又发现一个 bug，小窗下点击到 guide，然后调整为大窗口，这个时候多了一个返回的导航条，这种情况要考虑一下 |
已解决 |
|
@LCJove 代码有冲突了 |
#456