Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: tweet when release is published #667

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

thinkasany
Copy link
Collaborator

@thinkasany thinkasany commented Mar 19, 2024

action 仓库:https://github.com/nearform-actions/github-action-notify-twitter

需要佬们配置一下secret中的key

image

image
最终这边的tag会替换${{ github.event.ref }},

🤖 Ant Design Web3 just released ${{ github.event.ref }} ✨🎊✨ Check out the full release note: https://github.com/ant-design/ant-design-web3/releases/tag/${{ github.event.ref }}

即:
🤖 Ant Design Web3 just released @ant-design/web3@1.8.0 ✨🎊✨ Check out the full release note:
https://github.com/ant-design/ant-design-web3/releases/tag/@ant-design/web3@1.8.0

参考来源:https://github.com/ant-design/ant-design/blob/master/.github/workflows/release-tweet.yml

Copy link

changeset-bot bot commented Mar 19, 2024

⚠️ No Changeset found

Latest commit: 52945a5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Mar 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ant-design-web3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2024 2:46am

Copy link

github-actions bot commented Mar 19, 2024

@jeasonstudio
Copy link
Collaborator

screenshot-LZ0EKQzu@2x

@thinkasany
Copy link
Collaborator Author

screenshot-LZ0EKQzu@2x

看起来应该问题不大,也只能等下次发版的时候观察一下是否正常执行了

@thinkasany
Copy link
Collaborator Author

@jeasonstudio 大佬看看,这个是不是可以合啦

uses: nearform-actions/github-action-notify-twitter@v1
with:
message: |
🤖 Ant Design Web3 just released ${{ github.event.ref }} ✨🎊✨ Check out the full release note: https://github.com/ant-design/ant-design-web3/releases/tag/${{ github.event.ref }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里遗留一个疑问等这个 action 执行后看看效果,github.event.ref 是带 @ 符号的,好像在 tweet 中会变成圈别人,展示不正常。

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以换成 @​ 这个就可以了,长得一样,但是不是一个

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

如果是普通的 @ 肯定会有问题的

Copy link
Collaborator

@jeasonstudio jeasonstudio Mar 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

但是这个 @​ 是 release tag 里的,是不是应该在 ci 里做下 replace @thinkasany

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嗯,应该是在发布前做下替换

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

确实有问题 我一会儿补个pr
image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

哈哈哈,之前的每次推文都会艾特这个伙计

image

@jeasonstudio jeasonstudio marked this pull request as ready for review March 20, 2024 02:16
@jeasonstudio jeasonstudio merged commit bb07873 into ant-design:main Mar 20, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants