Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimize contributor list style #794

Merged
merged 5 commits into from
Apr 15, 2024
Merged

Conversation

kiner-tang
Copy link
Member

[中文版模板 / Chinese template]

💡 Background and solution

Before:

image

After:

image

🔗 Related issue link

Copy link

changeset-bot bot commented Apr 14, 2024

⚠️ No Changeset found

Latest commit: ebc780c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Apr 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ant-design-web3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 2:13am

Copy link

github-actions bot commented Apr 14, 2024

Preview is ready

Copy link

codecov bot commented Apr 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (62f1def) to head (ebc780c).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #794   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          666       666           
  Lines        20208     20208           
  Branches      1146      1146           
=========================================
  Hits         20208     20208           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thinkasany
Copy link
Collaborator

thinkasany commented Apr 14, 2024

帮我去掉一下这边,当时可能是看着移动端的调整了,preview移动端也有点问题,顺便兼容一下吧
image

image image image

@kiner-tang
Copy link
Member Author

帮我去掉一下这边,当时可能是看着移动端的调整了,preview移动端也有点问题,顺便兼容一下吧 image

image image image

好,我兼容一下移动端

@thinkasany
Copy link
Collaborator

有空滴话可以帮我看看这个怎么优化比较好,其实正常的话应该是解析outlet里面的东西一个一个渲染,然后这个组件就可以塞在那个里面了,但是感觉工作量太大了,我就先用了dom的操作。

image

@kiner-tang
Copy link
Member Author

有空滴话可以帮我看看这个怎么优化比较好,其实正常的话应该是解析outlet里面的东西一个一个渲染,然后这个组件就可以塞在那个里面了,但是感觉工作量太大了,我就先用了dom的操作。

image

我把这里逻辑抽离到 dumi-theme-antd-web3 里面去吧,在 web3 项目不太好处理。
image
image

const Contributors = React.lazy(() => import('../slots/Content/Contributors'));
const useStyle = createStyles(({ token, css }) => ({
contributorsContainer: css`
background: red;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

红色的背景是做什么用的

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

调试的,我把它删掉

@thinkasany
Copy link
Collaborator

lgtm

@kiner-tang kiner-tang merged commit 46b1946 into main Apr 15, 2024
12 checks passed
@kiner-tang kiner-tang deleted the feat-contributor-list branch April 15, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants