Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: import for bitcoin adapter #845

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

thinkasany
Copy link
Collaborator

[中文版模板 / Chinese template]

💡 Background and solution

重构引入原因如下:

引入React不使用,容易被格式化插件去掉,但是一但去掉会出现错误
如果没有引用 "packages/common/node_modules/@types/react/ts5.0",则无法命名 "BitcoinAdapterContext" 的推断类型。这很可能不可移植。需要类型注释。ts(2742)
image

image

Copy link

changeset-bot bot commented Apr 30, 2024

🦋 Changeset detected

Latest commit: 0f49349

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ant-design/web3-bitcoin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ant-design-web3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2024 2:23pm

Copy link

github-actions bot commented Apr 30, 2024

Preview is ready

Copy link
Member

@kiner-tang kiner-tang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

应该有一个配置可以禁止 prerrierrc 乱删代码的,不过这个重构也没啥问题,可以先合过去,我再搞个 pr 改一下配置

@kiner-tang kiner-tang merged commit ae6bd8a into ant-design:main Apr 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants