-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: set sideEffects false for enable treeshaking #879
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 4655cf8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
9fb2284
to
c47926d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #879 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 707 707
Lines 21365 21365
Branches 1198 1198
=========================================
Hits 21365 21365 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
有没有试一下添加 sideEffect 后,打包出来的产物提交小了多少呀,我们这边没有加 size-limit 的 action 没有太直观的感受。可以把本地打包产物的体积截个图放到 pr 上
是不是整个 beta 包,然后测试一下 |
标注 sideEffect false 后对我们自己 lib 的产物不会有影响,对于项目的影响也取决于项目使用了多少组件以及对应的 bundler 是否支持 tree-shaking; |
💡 Background and solution
除了 web3-icons 以外,其它包也都需要支持 treeshaking
🔗 Related issue link
#858