Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connector): auto display ens avatar #977

Merged
merged 4 commits into from
Jun 18, 2024
Merged

Conversation

jeasonstudio
Copy link
Collaborator

当连接的地址有 ens 信息时默认展示:
screenshot-msF1QmLK@2x

screenshot-nz4fkrdd@2x

Copy link

vercel bot commented Jun 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ant-design-web3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 18, 2024 2:42am

Copy link

changeset-bot bot commented Jun 17, 2024

🦋 Changeset detected

Latest commit: 1a4e6d2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@ant-design/web3-common Minor
@ant-design/web3-wagmi Minor
@ant-design/web3 Minor
@ant-design/web3-assets Patch
@ant-design/web3-bitcoin Patch
@ant-design/web3-eth-web3js Patch
@ant-design/web3-ethers-v5 Patch
@ant-design/web3-ethers Patch
@ant-design/web3-solana Patch
@example/eth-web3js Patch
@example/ethers-v5 Patch
@example/ethers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

github-actions bot commented Jun 17, 2024

Preview is ready

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (caf5569) to head (1a4e6d2).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #977   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          712       712           
  Lines        21629     21619   -10     
  Branches      1225      1223    -2     
=========================================
- Hits         21629     21619   -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@AmAzing129 AmAzing129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. I have no idea there is 'ens avatar'.

packages/web3/src/connect-button/connect-button.tsx Outdated Show resolved Hide resolved
@jeasonstudio
Copy link
Collaborator Author

可以参考 rainbowkit 的做法,给其他没有 ens avatar 的地址自动的选择一个头像:
screenshot-jmrBgatg@2x

@jeasonstudio jeasonstudio merged commit f1b85b9 into main Jun 18, 2024
12 checks passed
@jeasonstudio jeasonstudio deleted the feat-display-ens-avatar branch June 18, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants