fix(connect-modal): linear gradient gap #993
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 12eedc6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #993 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 720 720
Lines 22210 22210
Branches 1287 1287
=========================================
Hits 22210 22210 ☔ View full report in Codecov by Sentry. |
| @@ -216,7 +216,7 @@ const getThemeStyle = (token: ConnectModalToken): CSSInterpolation => { | |||
| [`&::before`]: { | |||
| content: '""', | |||
| position: 'absolute', | |||
| bottom: '100%', | |||
| bottom: `calc(100% - ${token.marginSM}px)`, | |||
There was a problem hiding this comment.
需要下移这么多吗？感觉不够精确，要看看那条缝到底是差在哪里
There was a problem hiding this comment.
问题好像出在这，模拟器缩放的时候导致的像素点的计算偏差，如果调整百分百去看就不存在这个bug。
我用手机看了没有这个问题，然后也切了其他的模拟器在 ’100%‘的情况下都是好了。
There was a problem hiding this comment.
如果实际并没有这个问题那感觉就不用管了
[中文版模板 / Chinese template]
💡 Background and solution
下移
{token.marginSM}的距离, 修复渐变区域的间隙before：
after：
🔗 Related issue link
#992