Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drawer 建议增加 keyboard - esc 关闭 #11628

Closed
1 task
zlab opened this issue Aug 6, 2018 · 10 comments
Closed
1 task

drawer 建议增加 keyboard - esc 关闭 #11628

zlab opened this issue Aug 6, 2018 · 10 comments

Comments

@zlab
Copy link

zlab commented Aug 6, 2018

  • I have searched the issues of this repository and believe that this is not a duplicate.

What problem does this feature solve?

和modal一样,esc关闭

What does the proposed API look like?

keyboard={true}

@ant-design-bot
Copy link
Contributor

Translation of this issue:


drawer Suggest to add keyboard - esc close

  • I have searched the issues of this repository and believe that this is not a duplicate.

What problem does this feature solve?

Like modal, esc is off

What does the proposed API look like?

Keyboard={true}

@dbismut
Copy link

dbismut commented Aug 10, 2018

Hi, I was able to implement this with react-hotkeys. Not incredibly pretty but it works.
https://codesandbox.io/s/748lxvmyw6

@frewillems
Copy link

This should be implemented in the components. Esc should trigger an onClose callback if this is set. Also valid for the drawer component for example.

@afc163
Copy link
Member

afc163 commented May 17, 2019

@jljsj33

@jljsj33
Copy link
Member

jljsj33 commented May 17, 2019

这个 @chenshuai2144 不是有整过吗??PR 还发在那。。

@afc163
Copy link
Member

afc163 commented May 17, 2019

@jljsj33 帮忙搞完吧

@chenshuai2144
Copy link
Contributor

merge 一下就就好了,主要是 prettier 风格问题 后来我们已经全部转向 prettier

@jljsj33
Copy link
Member

jljsj33 commented May 17, 2019

@chenshuai2144 我信你个鬼。。。

@jljsj33
Copy link
Member

jljsj33 commented May 17, 2019

drawer: ~1.9.0

@jljsj33 jljsj33 closed this as completed May 17, 2019
@afc163
Copy link
Member

afc163 commented May 17, 2019

@jljsj33 发个 MR 到 feature 分支上。

@afc163 afc163 reopened this May 17, 2019
jljsj33 added a commit that referenced this issue May 17, 2019
@afc163 afc163 closed this as completed May 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants