-
-
Notifications
You must be signed in to change notification settings - Fork 49k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed an issue about the component(RangePicker) could not select the … #15427
Conversation
Deploy preview for ant-design ready! Built with commit e69c4d7 |
Test failed. Please check. |
Well, I'll fix it |
Codecov Report
@@ Coverage Diff @@
## feature #15427 +/- ##
===========================================
- Coverage 94.13% 94.1% -0.03%
===========================================
Files 250 250
Lines 6635 6637 +2
Branches 1906 1907 +1
===========================================
Hits 6246 6246
- Misses 388 390 +2
Partials 1 1
Continue to review full report at Codecov.
|
感觉这个 test 不太对,日期应该和以前没变化才对…… |
恩... 看了下 确实是的 本来是改月份模式的 却又影响到了日期模式 而且琢磨了下日期模式面板的设计又确实应该如此 RangePicker组件改起来几乎是一环套一环的 确实挺多细节需要注意 我刚改了下 本地测试已经通过了之前的快照 我再看下了 稍后提交 |
.last() | ||
.getDOMNode().value, | ||
); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
弹出来的面板最好也检测一下两边是不是都可以点。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好的 我晚点添加下
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这两个 it 用一个 describe 包一起哈~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好的哈 我稍后添加下
…same month
First of all, thank you for your contribution! 😄
New feature please send pull request to feature branch, and rest to master branch.
Pull request will be merged after one of collaborators approve.
Please makes sure that these form are filled before submitting your pull request, thank you!
[中文版模板 / Chinese template]
🤔 This is a ...
👻 What's the background?
1.react-component/calendar#478
2.#13302
3.#15398
I added a submit for feature branch
📝 Changelog description
Fixed an issue about the component(RangePicker) could not select the same month
☑️ Self Check before Merge