Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master to feature #15638

Merged
merged 46 commits into from Mar 26, 2019
Merged

Merge master to feature #15638

merged 46 commits into from Mar 26, 2019

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Mar 25, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

👻 What's the background?

  1. Describe the source of requirement, like related issue link.

  2. Describe the problem and the scenario.

💡 Solution

  1. How to fix the problem, and list final API implementation and usage sample if that is an new feature.

  2. GIF or snapshot should be provided if includes UI/interactive modification.

📝 Changelog description

Describe changes from userside, and list all potential break changes or other risks.

  1. English description

  2. Chinese description (optional)

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

netlify bot commented Mar 25, 2019

Deploy preview for ant-design ready!

Built with commit f4a92d0

https://deploy-preview-15638--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Mar 25, 2019

Codecov Report

Merging #15638 into feature will increase coverage by 0.61%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #15638      +/-   ##
===========================================
+ Coverage    94.45%   95.06%   +0.61%     
===========================================
  Files          250      250              
  Lines         6669     6643      -26     
  Branches      1914     1942      +28     
===========================================
+ Hits          6299     6315      +16     
+ Misses         369      327      -42     
  Partials         1        1
Impacted Files Coverage Δ
components/card/index.tsx 98.63% <ø> (+14.63%) ⬆️
components/menu/MenuItem.tsx 77.77% <100%> (-5.56%) ⬇️
components/form/FormItem.tsx 98.85% <100%> (-0.02%) ⬇️
components/calendar/Header.tsx 96.2% <100%> (+8.86%) ⬆️
components/input/Password.tsx 100% <100%> (ø) ⬆️
components/menu/index.tsx 98.13% <100%> (+6.7%) ⬆️
components/empty/index.tsx 94.11% <0%> (-0.62%) ⬇️
components/config-provider/renderEmpty.tsx 86.66% <0%> (ø) ⬆️
components/modal/confirm.tsx 96.29% <0%> (ø) ⬆️
components/progress/progress.tsx 91.66% <0%> (ø) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e8d3ce...f4a92d0. Read the comment docs.

@afc163 afc163 merged commit e752ec3 into feature Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants