feat: add optional to support top and left slick dots (#16186) #16225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for ant-design ready! Built with commit 522ad80 |
Codecov Report
@@ Coverage Diff @@
## feature #16225 +/- ##
===========================================
- Coverage 95.27% 95.23% -0.05%
===========================================
Files 252 252
Lines 6773 6776 +3
Branches 1959 1938 -21
===========================================
Hits 6453 6453
- Misses 319 322 +3
Partials 1 1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## feature #16225 +/- ##
===========================================
- Coverage 95.29% 95.26% -0.04%
===========================================
Files 256 256
Lines 6845 6857 +12
Branches 1953 1959 +6
===========================================
+ Hits 6523 6532 +9
- Misses 321 324 +3
Partials 1 1
Continue to review full report at Codecov.
|
|
Demo 里也加一下 |
|
Demo和Doc都更新了 |
|
|
|
vertical 这个属性等于 |
|
@afc163 我也觉得是，是否需要考虑兼容性？ |
|
肯定要的，优先读 dotsPosition 吧，给 |
|
|
|
|
|
|
|
dots 是直接用的 react-slick 的 API 命名。 |
zombieJ
reviewed
Apr 24, 2019
zombieJ
reviewed
Apr 24, 2019
zombieJ
reviewed
Apr 24, 2019
zombieJ
reviewed
Apr 24, 2019
zombieJ
reviewed
Apr 24, 2019
zombieJ
reviewed
Apr 24, 2019
zombieJ
reviewed
Apr 25, 2019
zombieJ
reviewed
Apr 25, 2019
zombieJ
reviewed
Apr 25, 2019
zombieJ
reviewed
Apr 28, 2019
zombieJ
approved these changes
Apr 29, 2019
ztplz
approved these changes
Apr 29, 2019
chenshuai2144
added a commit
that referenced
this pull request
May 6, 2019
* use ul in list * update snapshot * update comment * feat: TreeSelect support `showSearch` in multiple mode (#15933) * update rc-tree-select * typo * update desc & snapshot * update desc & snapshot * check default showSearch * feat: table customizing variable (#15971) * feat: added table selected row color variable * fix: @table-selected-row-color default is inherit * feat: Upload support customize previewFile (#15984) * support preview file * use promise * dealy load * use canvas of render * use domHook of test * update demo * add snapshot * update types * update testcase * feat: form customizing variables (#15954) * fix: added styling form input background-color * feat: added '@form-warning-input-bg' variable * feat: added '@form-error-input-bg' variable * use li wrap with comment * feat: Support append theme less file with less-variable (#16118) * add override * add override support * update doc * feat: dropdown support set right icon * docs: update doc of dropdown component * style: format dropdown-button.md * test: update updateSnapshot * style: format dropdown-button.md * test: update updateSnapshot * test: update updateSnapshot * style: change style of dropdown-button demo * fix: fix document table order * feat: Support SkeletonAvatarProps.size accept number (#16078) (#16128) * chore:update style of demo * feat: Notification functions accept top, bottom and getContainer as arguments * drawer: add afterVisibleChange * rm onVisibleChange * update * feat: 🇭🇷 hr_HR locale (#16258) * Added Croatian locale * fixed lint error * ✅ Add test cases for hr_HR * 📝 update i18n documentation * feat: add `htmlFor` in Form.Item (#16278) * add htmlFor in Form.Item * update doc * feat: Button support `link` type (#16289) close #15892 * feat: Add Timeline.Item.position (#16148) (#16193) * fix: Timeline.pendingDot interface documentation there is a small problem (#16177) * feat: Add Timeline.Item.position (#16148) * doc: add version infomation for Timeline.Item.position * refactor: Update Tree & TreeSelect deps (#16330) * use CSSMotion * update snapshot * feat: Collapse support `expandIconPosition` (#16365) * update doc * support expandIconPosition * update snapshot * feat: Breadcrumb support DropDown (#16315) * breadcrumbs support drop down menu * update doc * add require less * fix test * fix md doc * less code * fix style warning * update snap * add children render test * feat: TreeNode support checkable * feat: add optional to support top and left slick dots (#16186) (#16225) * add optional to support top and left slick dots * update carousel snapshot * Update doc, add placement demo * update carousel placement demo snapshots * rename dots placement to position * update vertical as deprecated * rename dotsPosition to dotPosition * refine code * add warning testcase for vertical * remove unused warning * update expression * Additional test case for dotPosition * refactor: Upgrade `rc-tree-select` to support pure React motion (#16402) * upgrade `rc-tree-select` * update snapshot * 3.17.0 changelog * fix warning * fix review warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
👻 What's the background?
#16186 走马灯位置和自定义样式问题
💡 Solution
Add dots placement
📝 Changelog
Carousel Support dotsPlacement prop
Carousel 支持自定义面板指示点的位置
☑️ Self Check before Merge