Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skeleton prop for Button/Avator/Input/Progress #18237

Closed
afc163 opened this issue Aug 13, 2019 · 4 comments
Closed

skeleton prop for Button/Avator/Input/Progress #18237

afc163 opened this issue Aug 13, 2019 · 4 comments
Labels
4.x In Ant Design 4.0 💡 Feature Request Inactive

Comments

@afc163
Copy link
Member

afc163 commented Aug 13, 2019 

<Button skeleton />
<Avator skeleton />
<Input skeleton />

or

<Skeleton.Button />
<Skeleton.Avatar />
<Skeleton.Input />

ref: mui/material-ui#16786
@hsuanxyz hsuanxyz mentioned this issue Aug 13, 2019
Closed
@hi-rustin
Copy link
Contributor

我想做这个，按照顺序一个一个做吧。

This was referenced Nov 10, 2019
Closed
Merged
zombieJ pushed a commit that referenced this issue Nov 21, 2019
@hi-rustin @zombieJ
feat: Add skeleton button (#19699)
060b7de 
* #18237 add skeleton button

* update snapshot

* refactoring demo code

* lint code

* update test snapshots

* add test

* update snapshot

* fix deps lint issue

* set avatar siz and update test snapshots

* fix lint issue

* remove button and just keep skeleton

* add active switch for button demo

* add size and shape radio for skeleton button demo

* add button tests

* add skeleton tests

* update doc

* update test snapshots

* omit avatar and button props

* refactoring skeleton and update test snapshots
@hi-rustin hi-rustin mentioned this issue Nov 22, 2019
Merged
14 tasks
afc163 pushed a commit that referenced this issue Dec 3, 2019
@hi-rustin @afc163
feat: add skeleton avatar (#19898)
7a5fc8b 
* move avatar default props into skeleton

* #18237 complete skeleton avatar

* update skeleton avatar docs

* add more tests for skeleton avatar

* refactor class and props name

* revert Avatar props name

* combine avatar and button demo

* update demo and test snapshots

* move active props into element
@afc163 afc163 added the 4.x In Ant Design 4.0 label Dec 3, 2019
@hi-rustin hi-rustin mentioned this issue Dec 15, 2019
Merged
14 tasks
zombieJ pushed a commit that referenced this issue Dec 19, 2019
@hi-rustin @zombieJ
feat: add Input element for Skeleton (#20264)
1c4bae5 
* complete skeleton input element (#18237)

* update test snapshots

* update skeleton doc

* add more test for skeleton input

* fix test snapshots issue
@afc163 afc163 closed this as completed Dec 31, 2019
@hi-rustin
Copy link
Contributor

@afc163 The Progress still in progress.😂

@afc163
Copy link
Member Author

afc163 commented Dec 31, 2019 •
edited

再单独做就好了，Progress 不是很常用，我只是当时想到就写在这里。肯定也不止 Progress，Table/Card/List/PageHeader/Alert/Steps/Menu 等等组件都可以做也更常用。

@hi-rustin
Copy link
Contributor

再单独做就好了，Progress 不是很常用，我只是当时想到就写在这里。肯定也不止 Progress，Table/Card/List/PageHeader/Alert/Steps/Menu 等等组件都可以做也更常用。

要不我晚点建个issue，然后加个help label就可以慢慢做了。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
4.x In Ant Design 4.0 💡 Feature Request Inactive
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@afc163 @ant-design-bot @hi-rustin