Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add skeleton button #19699

Merged
merged 19 commits into from Nov 21, 2019
Merged

feat: Add skeleton button #19699

merged 19 commits into from Nov 21, 2019

Conversation

hi-rustin
Copy link
Contributor

@hi-rustin hi-rustin commented Nov 12, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

#18237

馃挕 Background and solution

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English Add skeleton button
馃嚚馃嚦 Chinese 鏂板楠ㄦ灦鎸夐挳

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/skeleton/demo/button.md
View rendered components/skeleton/index.en-US.md
View rendered components/skeleton/index.zh-CN.md

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@hi-rustin hi-rustin changed the title feat:Add skeleton button feat: Add skeleton button Nov 12, 2019
@netlify
Copy link

@netlify netlify bot commented Nov 12, 2019

Deploy preview for ant-design ready!

Built with commit 977a5d4

https://deploy-preview-19699--ant-design.netlify.com

@codecov
Copy link

@codecov codecov bot commented Nov 12, 2019

Codecov Report

Merging #19699 into 4.0-prepare will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           4.0-prepare   #19699      +/-   ##
===============================================
+ Coverage        97.46%   97.49%   +0.03%     
===============================================
  Files              288      291       +3     
  Lines             7219     7231      +12     
  Branches          1957     1996      +39     
===============================================
+ Hits              7036     7050      +14     
+ Misses             183      181       -2
Impacted Files Coverage 螖
components/skeleton/Button.tsx 100% <100%> (酶)
components/skeleton/Skeleton.tsx 100% <100%> (酶)
components/skeleton/index.tsx 100% <100%> (+4.34%) 猬嗭笍
components/skeleton/Avatar.tsx 100% <100%> (酶) 猬嗭笍
components/skeleton/SkeletonElement.tsx 100% <100%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 209e293...977a5d4. Read the comment docs.

@shaodahong shaodahong mentioned this pull request Nov 12, 2019
14 tasks
@buildsize
Copy link

@buildsize buildsize bot commented Nov 13, 2019

File name Previous Size New Size Change
package-lock.json 973.67聽KB 976.97聽KB 3.3聽KB (0%)

@hi-rustin
Copy link
Contributor Author

@hi-rustin hi-rustin commented Nov 14, 2019

ping~

components/skeleton/demo/button.md Outdated Show resolved Hide resolved
@hi-rustin
Copy link
Contributor Author

@hi-rustin hi-rustin commented Nov 17, 2019

@zombieJ The CI failed, it seem because react-component/table react-component/table@ce44084

@zombieJ
Copy link
Member

@zombieJ zombieJ commented Nov 17, 2019

Let me check. Thanks

@hi-rustin
Copy link
Contributor Author

@hi-rustin hi-rustin commented Nov 17, 2019

rebased.

components/skeleton/index.zh-CN.md Outdated Show resolved Hide resolved
@yoyo837
Copy link
Contributor

@yoyo837 yoyo837 commented Nov 19, 2019

瑕嗙洊鐜囦笉澶燂紝娣诲姞娴嬭瘯鐢ㄤ緥銆

@hi-rustin
Copy link
Contributor Author

@hi-rustin hi-rustin commented Nov 19, 2019

瑕嗙洊鐜囦笉澶燂紝娣诲姞娴嬭瘯鐢ㄤ緥銆

宸叉坊鍔犮

@yoyo837 yoyo837 requested a review from zombieJ Nov 19, 2019
@zombieJ
Copy link
Member

@zombieJ zombieJ commented Nov 20, 2019

md file conflict

@hi-rustin
Copy link
Contributor Author

@hi-rustin hi-rustin commented Nov 20, 2019

md file conflict

resolved.

components/skeleton/Button.tsx Outdated Show resolved Hide resolved
@zombieJ zombieJ merged commit 060b7de into ant-design:4.0-prepare Nov 21, 2019
21 checks passed
@hi-rustin hi-rustin deleted the 4.0-prepare branch Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants