New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the focusing input be optional, when trigger the "onSearch" event on Input.Search component #20297
Comments
We can add mobile device detection before focus input by using https://github.com/juliangruber/is-mobile if (!isMobile()) {
this.input.focus();
} Could you send us a PR to fix it? |
Hello @YaoKaiLun. We totally like your proposal/feedback, welcome to send us Pull Request for it. Please send your Pull Request to proper branch (feature branch for new feature, master for bugfix and other changes), fill the [Pull Request Template] here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. Appreciate it advance and we are looking forword to your contribution! 你好 @YaoKaiLun, 我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到正确的分支(新特性发到 feature 分支,其他发到 master 分支),务必填写 Pull Request 内的预设模板,提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献! |
Why not use prop like |
开先河的感觉。 |
@yoyo837 It is not But I think it is better to reduce those props which are too complex to understand by setting a default hehavior. |
What problem does this feature solve?
I use Input.Search component in my website, and my website is responsible. When i click search button in the mobile, it will trigger focusing input, and it cause keyboard pop up.
I think it will be better to have a parameter to controller this feature that if focusing input after triggering the "onSearch" event.
What does the proposed API look like?
Add a parameter "focusAfterSearch", the default value is "true".
ant-design/components/input/Search.tsx
Line 50 in 333f63b
The text was updated successfully, but these errors were encountered: