Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tag - conflict of onClick and onClose #20344

Closed
1 task
bgunseli opened this issue Dec 19, 2019 · 1 comment · Fixed by #20355
Closed
1 task

tag - conflict of onClick and onClose #20344

bgunseli opened this issue Dec 19, 2019 · 1 comment · Fixed by #20355
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request.

Comments

@bgunseli
Copy link

  • I have searched the issues of this repository and believe that this is not a duplicate.

Reproduction link

Edit on CodeSandbox

Steps to reproduce

1.create a tag
2.click the close button

What is expected?

Do not trigger the onClick event when I click the close button.

What is actually happening?

When I click the close button, both the onClose and onClick events are triggered.

Environment Info
antd 3.26.3
React 16.9.0
System macOS Catalina
Browser Chrome

#14670 like this issue, but this is happening on Tag.

@afc163 afc163 added the help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. label Dec 19, 2019
@ant-design-bot
Copy link
Contributor

Hello @bgunseli. We totally like your proposal/feedback, welcome to send us Pull Request for it. Please send your Pull Request to proper branch (feature branch for new feature, master for bugfix and other changes), fill the [Pull Request Template] here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. Appreciate it advance and we are looking forword to your contribution!

你好 @bgunseli, 我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到正确的分支(新特性发到 feature 分支,其他发到 master 分支),务必填写 Pull Request 内的预设模板,提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献!

giphy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants