Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade all rc-* to dumi 2 + father 4 #45491

Closed
23 tasks done
afc163 opened this issue Oct 23, 2023 · 9 comments
Closed
23 tasks done

Upgrade all rc-* to dumi 2 + father 4 #45491

afc163 opened this issue Oct 23, 2023 · 9 comments
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. unconfirmed

Comments

@afc163
Copy link
Member

afc163 commented Oct 23, 2023

Enable
fix vercel preview build:
图片

Documents

@afc163 afc163 added the help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. label Oct 23, 2023
@github-actions
Copy link
Contributor

Hello @afc163. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to proper branch (feature branch for the new feature, master for bugfix and other changes), fill the Pull Request Template here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. We appreciate your effort in advance and looking forward to your contribution!

你好 @afc163,我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到正确的分支(新特性发到 feature 分支,其他发到 master 分支),务必填写 Pull Request 内的预设模板,提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献。

giphy

@yoyo837 yoyo837 changed the title Upgrade all rc-* to dumi 2 Upgrade all rc-* to dumi 2 + fatch 4 Oct 23, 2023
@yoyo837 yoyo837 changed the title Upgrade all rc-* to dumi 2 + fatch 4 Upgrade all rc-* to dumi 2 + fatcher 4 Oct 23, 2023
@yoyo837 yoyo837 changed the title Upgrade all rc-* to dumi 2 + fatcher 4 Upgrade all rc-* to dumi 2 + father 4 Oct 23, 2023
@Wxh16144
Copy link
Member

Wxh16144 commented Oct 23, 2023

还可以把 rc- 系列的 homepage 都改为 https://react-component.github.io/{name}

导航页也可以考虑更新一下? https://react-component.github.io/

@yoyo837
Copy link
Contributor

yoyo837 commented Nov 15, 2023

有些仓库即使 dumi@2 + fatcher@4, vercel 仍然红的

@DBSDs
Copy link
Contributor

DBSDs commented Nov 16, 2023

有些仓库即使 dumi@2 + fatcher@4, vercel 仍然红的

是的,我也不清楚为什么会报错,我需要知道 vercel 部署错误的详细信息。
本来想达成 homepage 都改为 https://react-component.github.io/{name},但是某些库在没有 base url,如果我加上的话会导致 vercel 部署不正确 -> 页面显示为空。
最后 rc-test 没有引入dumi,因此我并没有对此仓库做升级。

@yoyo837
Copy link
Contributor

yoyo837 commented Nov 17, 2023

有些仓库即使 dumi@2 + fatcher@4, vercel 仍然红的

是的,我也不清楚为什么会报错,我需要知道 vercel 部署错误的详细信息。 本来想达成 homepage 都改为 https://react-component.github.io/{name},但是某些库在没有 base url,如果我加上的话会导致 vercel 部署不正确 -> 页面显示为空。 最后 rc-test 没有引入dumi,因此我并没有对此仓库做升级。

这个只能让有权限的Core member去看了.

@afc163
Copy link
Member Author

afc163 commented Nov 17, 2023

是的,我也不清楚为什么会报错,我需要知道 vercel 部署错误的详细信息。

除了 @zombieJ 都看不到。

@DBSDs
Copy link
Contributor

DBSDs commented Nov 18, 2023

@afc163 father 从2.x 升级至 4.0 删除了 test 命令,不同仓库中有 umi-test 也有 rc-test,是用哪个?

@yoyo837
Copy link
Contributor

yoyo837 commented Dec 21, 2023

@afc163 father 从2.x 升级至 4.0 删除了 test 命令,不同仓库中有 umi-test 也有 rc-test,是用哪个?

可以参考 react-component/upload#523

@afc163
Copy link
Member Author

afc163 commented Apr 12, 2024

All done!

@afc163 afc163 closed this as completed Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. unconfirmed
Projects
None yet
Development

No branches or pull requests

4 participants