Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spin: lifecycle method migrate #11786

Closed
wants to merge 0 commits into from
Closed

Spin: lifecycle method migrate #11786

wants to merge 0 commits into from

Conversation

dancerphil
Copy link
Contributor

  • Make sure that you propose PR to right branch: bugfix for master, feature for latest active branch feature-x.x.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

no.

elif isNewFeature :

#9792

test is added: #11682

  • Add unit tests for the feature.

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Aug 19, 2018

Deploy preview for ant-design ready!

Built with commit 609c5c7

https://deploy-preview-11786--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Aug 21, 2018

Codecov Report

Merging #11786 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #11786   +/-   ##
=======================================
  Coverage   92.25%   92.25%           
=======================================
  Files         210      210           
  Lines        5490     5490           
  Branches     1547     1547           
=======================================
  Hits         5065     5065           
  Misses        421      421           
  Partials        4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 609c5c7...609c5c7. Read the comment docs.

@yesmeck
Copy link
Member

yesmeck commented Sep 29, 2018

Merged in 6867ef9. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants