Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Steps): add subTitle propType declaration for Steps.Step component #18525

Merged
merged 1 commit into from Aug 28, 2019

Conversation

jtsang4
Copy link
Contributor

@jtsang4 jtsang4 commented Aug 28, 2019

🤔 This is a ...

  • TypeScript definition update

🔗 Related issue link

There is no link, just a issue find in usage that the <Steps.Step> component dosen't have subTitle prop type declaration but it is supported by rc-steps and exposed by the document.

💡 Background and solution

Add subTitle prop in StepProps interface.

📝 Changelog

Language Changelog
🇺🇸 English Fix <Steps.Step> component's subTitle prop types
🇨🇳 Chinese 修复 <Steps.Step> 组件 subTitle 属性类型

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

netlify bot commented Aug 28, 2019

Deploy preview for ant-design ready!

Built with commit b5e2b47

https://deploy-preview-18525--ant-design.netlify.com

@jtsang4 jtsang4 changed the title type(Steps): add subTitle propType declaration for Steps.Step component fix(Steps): add subTitle propType declaration for Steps.Step component Aug 28, 2019
@afc163 afc163 merged commit cbb172d into ant-design:master Aug 28, 2019
3 of 6 checks passed
@codecov
Copy link

codecov bot commented Aug 28, 2019

Codecov Report

Merging #18525 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18525   +/-   ##
=======================================
  Coverage   96.73%   96.73%           
=======================================
  Files         280      280           
  Lines        7532     7532           
  Branches     2095     2095           
=======================================
  Hits         7286     7286           
  Misses        244      244           
  Partials        2        2
Impacted Files Coverage Δ
components/steps/index.tsx 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab6dd46...b5e2b47. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants