Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add PageHeader css background #18632

Closed

Conversation

maiqingqiang
Copy link

add page-header css background

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

上一版本的 PageHeader 是自带白色背景的,更新到 v3.23.1 颜色就没有了。所以把白色背景补回来

📝 Changelog

Language Changelog
🇺🇸 English add page-header css background
🇨🇳 Chinese 给 PageHeader 添加背景色

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

add page-header  css background
@netlify
Copy link

netlify bot commented Sep 3, 2019

Deploy preview for ant-design ready!

Built with commit 26f7135

https://deploy-preview-18632--ant-design.netlify.com

@maiqingqiang maiqingqiang changed the title add page-header css background add PageHeader css background Sep 3, 2019
@codecov
Copy link

codecov bot commented Sep 3, 2019

Codecov Report

Merging #18632 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18632   +/-   ##
=======================================
  Coverage   96.74%   96.74%           
=======================================
  Files         281      281           
  Lines        7552     7552           
  Branches     2062     2093   +31     
=======================================
  Hits         7306     7306           
  Misses        244      244           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa9b9db...26f7135. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Sep 3, 2019

Codecov Report

Merging #18632 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18632   +/-   ##
=======================================
  Coverage   96.74%   96.74%           
=======================================
  Files         281      281           
  Lines        7552     7552           
  Branches     2062     2093   +31     
=======================================
  Hits         7306     7306           
  Misses        244      244           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa9b9db...26f7135. Read the comment docs.

@dengfuping
Copy link
Contributor

  • @maiqingqiang 优化后的 PageHeader 不内置背景颜色了,应该由底色决定。

@dengfuping dengfuping closed this Sep 3, 2019
@dengfuping
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants