Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: transfer footer to rc-footer #18890

Merged
merged 4 commits into from Sep 19, 2019
Merged

chore: transfer footer to rc-footer #18890

merged 4 commits into from Sep 19, 2019

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Sep 19, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

馃挕 Background and solution

Use https://github.com/react-component/footer

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: draft label Sep 19, 2019
Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@netlify
Copy link

netlify bot commented Sep 19, 2019

Deploy preview for ant-design ready!

Built with commit d2a6db4

https://deploy-preview-18890--ant-design.netlify.com

@lgtm-com
Copy link

lgtm-com bot commented Sep 19, 2019

This pull request introduces 4 alerts when merging 9d3259c into a5bb161 - view on LGTM.com

new alerts:

  • 4 for Unused variable, import, function or class

@afc163 afc163 changed the title 馃拕 transfer footer to rc-footer chore: transfer footer to rc-footer Sep 19, 2019
@codecov
Copy link

codecov bot commented Sep 19, 2019

Codecov Report

Merging #18890 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18890   +/-   ##
=======================================
  Coverage   96.91%   96.91%           
=======================================
  Files         281      281           
  Lines        7548     7548           
  Branches     2092     2103   +11     
=======================================
  Hits         7315     7315           
  Misses        231      231           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update a5bb161...d2a6db4. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Sep 19, 2019

This pull request introduces 1 alert when merging 7f84b1e into a5bb161 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@afc163 afc163 marked this pull request as ready for review September 19, 2019 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant