Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Tabs support slide #19061

Closed
wants to merge 8 commits into from
Closed

feat: Tabs support slide #19061

wants to merge 8 commits into from

Conversation

hengkx
Copy link
Member

@hengkx hengkx commented Sep 29, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

ref #19015

💡 Background and solution

slide
拉错分支了,看看有没有问题把 。。。

📝 Changelog

Language Changelog
🇺🇸 English Tabs slide support
🇨🇳 Chinese Tabs支持滑动

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered CHANGELOG.en-US.md
View rendered CHANGELOG.zh-CN.md
View rendered components/tabs/demo/page.md
View rendered components/tabs/demo/slide.md
View rendered components/tabs/index.en-US.md
View rendered components/tabs/index.zh-CN.md

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@netlify
Copy link

netlify bot commented Sep 29, 2019

Deploy preview for ant-design ready!

Built with commit 6cb4de2

https://deploy-preview-19061--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Sep 29, 2019

Codecov Report

❗ No coverage uploaded for pull request base (feature@dc0dfea). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             feature   #19061   +/-   ##
==========================================
  Coverage           ?   97.38%           
==========================================
  Files              ?      280           
  Lines              ?     7530           
  Branches           ?     2099           
==========================================
  Hits               ?     7333           
  Misses             ?      196           
  Partials           ?        1
Impacted Files Coverage Δ
components/affix/index.tsx 97.32% <ø> (ø)
components/typography/Base.tsx 100% <ø> (ø)
components/input/TextArea.tsx 96.36% <ø> (ø)
components/tabs/index.tsx 96.96% <100%> (ø)
components/upload/Upload.tsx 99.24% <100%> (ø)
components/tabs/TabBar.tsx 100% <100%> (ø)
components/upload/utils.tsx 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc0dfea...6cb4de2. Read the comment docs.

@yoyo837
Copy link
Contributor

yoyo837 commented Sep 30, 2019

Commits should be clean

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants