fix: test antd dark theme component #20012

ycjcl868 · 2019-11-29T16:11:58Z

only for dark component preview, not merge before removing [WIP]

Close #19971.

🤔 This is a ...

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language	Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

Doc is updated/provided or not needed
Demo is updated/provided or not needed
TypeScript definition is updated/provided or not needed
Changelog is provided or not needed

netlify · 2019-11-29T16:16:00Z

Deploy preview for ant-design ready!

Built with commit 4be9e9d

https://deploy-preview-20012--ant-design.netlify.com

codecov · 2019-11-29T16:22:32Z

Codecov Report

Merging #20012 into 4.0-prepare will increase coverage by <.01%.
The diff coverage is 100%.

@@               Coverage Diff               @@
##           4.0-prepare   #20012      +/-   ##
===============================================
+ Coverage        97.56%   97.56%   +<.01%     
===============================================
  Files              294      294              
  Lines             7227     7231       +4     
  Branches          2001     2000       -1     
===============================================
+ Hits              7051     7055       +4     
  Misses             176      176

Impacted Files	Coverage Δ
components/progress/progress.tsx	`100% <ø> (ø)`	⬆️
components/empty/simple.tsx	`100% <100%> (ø)`	⬆️
components/empty/empty.tsx	`100% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d76283f...4be9e9d. Read the comment docs.

codesandbox-ci · 2019-11-29T16:40:28Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4be9e9d:

Sandbox	Source
antd reproduction template	Configuration

todo · 2019-12-03T04:22:07Z

use `@{ant-prefix}`

ant-design/components/empty/style/index.less

Lines 54 to 59 in d6f41db

    
           // TODO: use `@{ant-prefix}` 
        
           .default-empty-img { 
        
             // not support the definition because the less variables have no meaning 
        
             & when (@theme = dark) { 
        
               &-ellipse { 
        
                 fill-opacity: 0.08;

This comment was generated by todo based on a `TODO` comment in `d6f41db` in #20012. cc @ant-design.

todo · 2019-12-03T06:01:08Z

use `@{ant-prefix}`

ant-design/components/empty/style/index.less

Lines 54 to 59 in 22aba08

    
           // TODO: use `@{ant-prefix}` 
        
           .default-empty-img { 
        
             // not support the definition because the less variables have no meaning 
        
             & when (@theme = dark) { 
        
               &-ellipse { 
        
                 fill-opacity: 0.08;

This comment was generated by todo based on a `TODO` comment in `22aba08` in #20012. cc @ant-design.

todo · 2019-12-03T07:39:55Z

use `@{ant-prefix}`

ant-design/components/empty/style/index.less

Lines 54 to 59 in e2251f5

    
           // TODO: use `@{ant-prefix}` 
        
           .default-empty-img { 
        
             // not support the definition because the less variables have no meaning 
        
             & when (@theme = dark) { 
        
               &-ellipse { 
        
                 fill-opacity: 0.08;

This comment was generated by todo based on a `TODO` comment in `e2251f5` in #20012. cc @ant-design.

todo · 2019-12-03T07:40:29Z

use `@{ant-prefix}`

ant-design/components/empty/style/index.less

Lines 54 to 59 in dc90c21

    
           // TODO: use `@{ant-prefix}` 
        
           .default-empty-img { 
        
             // not support the definition because the less variables have no meaning 
        
             & when (@theme = dark) { 
        
               &-ellipse { 
        
                 fill-opacity: 0.08;

This comment was generated by todo based on a `TODO` comment in `dc90c21` in #20012. cc @ant-design.

todo · 2019-12-03T08:47:45Z

use `@{ant-prefix}`

ant-design/components/empty/style/index.less

Lines 54 to 59 in 53e663a

    
           // TODO: use `@{ant-prefix}` 
        
           .default-empty-img { 
        
             // not support the definition because the less variables have no meaning 
        
             & when (@theme = dark) { 
        
               &-ellipse { 
        
                 fill-opacity: 0.08;

This comment was generated by todo based on a `TODO` comment in `53e663a` in #20012. cc @ant-design.

todo · 2019-12-03T08:49:23Z

use `@{ant-prefix}`

ant-design/components/empty/style/index.less

Lines 54 to 59 in 0da761d

    
           // TODO: use `@{ant-prefix}` 
        
           .default-empty-img { 
        
             // not support the definition because the less variables have no meaning 
        
             & when (@theme = dark) { 
        
               &-ellipse { 
        
                 fill-opacity: 0.08;

This comment was generated by todo based on a `TODO` comment in `0da761d` in #20012. cc @ant-design.

zombieJ · 2019-12-03T08:52:22Z

简洁了很多👍

todo · 2019-12-03T11:57:24Z

use `@{ant-prefix}`

ant-design/components/empty/style/index.less

Lines 54 to 59 in d8ab994

    
           // TODO: use `@{ant-prefix}` 
        
           .default-empty-img { 
        
             // not support the definition because the less variables have no meaning 
        
             & when (@theme = dark) { 
        
               &-ellipse { 
        
                 fill-opacity: 0.08;

This comment was generated by todo based on a `TODO` comment in `d8ab994` in #20012. cc @ant-design.

ycjcl868 · 2019-12-03T12:22:20Z

components/progress/progress.tsx

@@ -49,7 +49,8 @@ export default class Progress extends React.Component<ProgressProps> {
    type: 'line',
    percent: 0,
    showInfo: true,
-    trailColor: '#f3f3f3',
+    // null for different theme definition
+    trailColor: null,


@zombieJ trailColor 传 null 目的是避免 rc-progress 使用 defaultProps ，将 trail color 加到 style 上。

ycjcl868 · 2019-12-03T12:24:02Z

components/steps/style/index.less

@@ -5,7 +5,6 @@
 @process-icon-color: @primary-color;
 @process-title-color: @heading-color;
 @process-description-color: @text-color;
-@process-tail-color: @border-color-split;


put into default.less for theme

chore: test antd dark theme component

8ad5b73

pr-triage bot added the PR: unreviewed label Nov 29, 2019

auto-add-label bot added the bug label Nov 29, 2019

fix: just for preview

c76467b

ycjcl868 changed the title ~~fix: test antd dark theme component~~ [WIP] fix: test antd dark theme component Nov 29, 2019

pr-triage bot removed the PR: unreviewed label Nov 29, 2019

weekly-digest bot mentioned this pull request Dec 1, 2019

Weekly Digest (24 November, 2019 - 1 December, 2019) #20028

Closed

ycjcl868 added 13 commits December 1, 2019 21:23

fix: pagination dark theme

673f86b

fix: cascader and input-number-handler bg

d388c1d

feat: @mention-textarea-bg

689d9b7

feat: @theme dark, default

327011d

feat: @dropdown-menu-submenu-disabled-bg

f7f17c8

Merge 4.0-prepare into fix-dark-theme

5590ba0

feat: date-picker, steps less dark

99f8d84

fix: @input-number-handler-bg

208d954

fix: @mentions-dropdown-bg

aa963b5

fix: remove @import dark

d94845f

fix: reset site style

6fa168c

fix: reset md style

646a1d0

fix: md style

fcae72c

ycjcl868 changed the title ~~[WIP] fix: test antd dark theme component~~ fix: test antd dark theme component Dec 1, 2019

pr-triage bot added the PR: unreviewed label Dec 1, 2019

ycjcl868 added 5 commits December 2, 2019 10:53

fix: colorPalette and @tree-bg

28306fb

feat: @radio-dot-disabled-color

dc1d187

fix: datepicker bg @time-picker-panel-inner-bg

898311c

fix: table header dark

505b12a

fix: components notification

d5d2051

fix: progress trailColor support dark theme

22aba08

fix: @theme condition

e2251f5

fix: @theme default

dc90c21

tweak: antd dark theme in as required usage

53e663a

📝 dark theme usage

0da761d

fix: border-color use solid color

d8ab994

fix: empty prefix className, update snapshot

62952a8

ycjcl868 commented Dec 3, 2019

View reviewed changes

ycjcl868 added 2 commits December 3, 2019 21:14

fix: @link hover,active color

7b82687

fix: dist build pipline

e16b17b

zombieJ approved these changes Dec 3, 2019

View reviewed changes

pr-triage bot added PR: reviewed-approved and removed PR: unreviewed labels Dec 3, 2019

fix: remove dark.less import

4be9e9d

pr-triage bot added PR: unreviewed and removed PR: reviewed-approved labels Dec 3, 2019

ycjcl868 merged commit c247e92 into 4.0-prepare Dec 3, 2019

ycjcl868 deleted the fix-dark-theme branch December 3, 2019 15:38

pr-triage bot added PR: merged and removed PR: unreviewed labels Dec 3, 2019

weekly-digest bot mentioned this pull request Dec 8, 2019

Weekly Digest (1 December, 2019 - 8 December, 2019) #20136

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: test antd dark theme component #20012

fix: test antd dark theme component #20012

ycjcl868 commented Nov 29, 2019 •

edited

netlify bot commented Nov 29, 2019 •

edited

codecov bot commented Nov 29, 2019 •

edited

codesandbox-ci bot commented Nov 29, 2019 •

edited

todo bot commented Dec 3, 2019

todo bot commented Dec 3, 2019

todo bot commented Dec 3, 2019

todo bot commented Dec 3, 2019

todo bot commented Dec 3, 2019

todo bot commented Dec 3, 2019

zombieJ commented Dec 3, 2019

todo bot commented Dec 3, 2019

ycjcl868 Dec 3, 2019

ycjcl868 Dec 3, 2019

fix: test antd dark theme component #20012

fix: test antd dark theme component #20012

Conversation

ycjcl868 commented Nov 29, 2019 • edited

🤔 This is a ...

🔗 Related issue link

💡 Background and solution

📝 Changelog

☑️ Self Check before Merge

netlify bot commented Nov 29, 2019 • edited

codecov bot commented Nov 29, 2019 • edited

Codecov Report

codesandbox-ci bot commented Nov 29, 2019 • edited

todo bot commented Dec 3, 2019

use `@{ant-prefix}`

This comment was generated by todo based on a TODO comment in d6f41db in #20012. cc @ant-design.

todo bot commented Dec 3, 2019

use `@{ant-prefix}`

This comment was generated by todo based on a TODO comment in 22aba08 in #20012. cc @ant-design.

todo bot commented Dec 3, 2019

use `@{ant-prefix}`

This comment was generated by todo based on a TODO comment in e2251f5 in #20012. cc @ant-design.

todo bot commented Dec 3, 2019

use `@{ant-prefix}`

This comment was generated by todo based on a TODO comment in dc90c21 in #20012. cc @ant-design.

todo bot commented Dec 3, 2019

use `@{ant-prefix}`

This comment was generated by todo based on a TODO comment in 53e663a in #20012. cc @ant-design.

todo bot commented Dec 3, 2019

use `@{ant-prefix}`

This comment was generated by todo based on a TODO comment in 0da761d in #20012. cc @ant-design.

zombieJ commented Dec 3, 2019

todo bot commented Dec 3, 2019

use `@{ant-prefix}`

This comment was generated by todo based on a TODO comment in d8ab994 in #20012. cc @ant-design.

ycjcl868 Dec 3, 2019

Choose a reason for hiding this comment

ycjcl868 Dec 3, 2019

Choose a reason for hiding this comment

ycjcl868 commented Nov 29, 2019 •

edited

netlify bot commented Nov 29, 2019 •

edited

codecov bot commented Nov 29, 2019 •

edited

codesandbox-ci bot commented Nov 29, 2019 •

edited

This comment was generated by todo based on a `TODO` comment in `d6f41db` in #20012. cc @ant-design.

This comment was generated by todo based on a `TODO` comment in `22aba08` in #20012. cc @ant-design.

This comment was generated by todo based on a `TODO` comment in `e2251f5` in #20012. cc @ant-design.

This comment was generated by todo based on a `TODO` comment in `dc90c21` in #20012. cc @ant-design.

This comment was generated by todo based on a `TODO` comment in `53e663a` in #20012. cc @ant-design.

This comment was generated by todo based on a `TODO` comment in `0da761d` in #20012. cc @ant-design.

This comment was generated by todo based on a `TODO` comment in `d8ab994` in #20012. cc @ant-design.